Skip to content

Conversation

@eldering
Copy link
Member

This resource leak was found by Coverity scan.

This resource leak was found by Coverity scan.
@eldering eldering requested a review from meisterT February 25, 2025 21:19
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this is breaking related tests, but I don't immediately see what's wrong. Can have a closer look tomorrow evening

@eldering
Copy link
Member Author

Wait, this is breaking related tests, but I don't immediately see what's wrong. Can have a closer look tomorrow evening

Yeah, I also had to look. The fix is actually wrong, see man putenv. The pointed to string becomes part of the environment. So we should not free the strdup copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants